mike-jumper commented on code in PR #884:
URL: https://github.com/apache/guacamole-client/pull/884#discussion_r1225431483
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/pom.xml:
##########
@@ -74,6 +74,23 @@
<groupId>com.onelogin</groupId>
<artifactId>java-saml</artifactId>
<version>2.9.0</version>
+ <!--
+ Replace vulnerable version of Woodstox until upstream
+ releases a version with fixed dependencies
+ -->
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.woodstox</groupId>
+ <artifactId>woodstox-core</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- Woodstox -->
+ <dependency>
+ <groupId>com.fasterxml.woodstox</groupId>
+ <artifactId>woodstox-core</artifactId>
+ <version>5.4.0</version>
Review Comment:
I believe the upstream SAML library corrected this by updating their version
of xmlsec, and the change there is minimal:
https://github.com/SAML-Toolkits/java-saml/pull/377
We could do that instead of overriding Woodstox, and trust that the change
is equivalent to what java-saml has done but not released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
