Inperpetuammemoriam commented on code in PR #884:
URL: https://github.com/apache/guacamole-client/pull/884#discussion_r1225462276
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/pom.xml:
##########
@@ -74,6 +74,23 @@
<groupId>com.onelogin</groupId>
<artifactId>java-saml</artifactId>
<version>2.9.0</version>
+ <!--
+ Replace vulnerable version of Woodstox until upstream
+ releases a version with fixed dependencies
+ -->
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.woodstox</groupId>
+ <artifactId>woodstox-core</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <!-- Woodstox -->
+ <dependency>
+ <groupId>com.fasterxml.woodstox</groupId>
+ <artifactId>woodstox-core</artifactId>
+ <version>5.4.0</version>
Review Comment:
Correct me, if I'm wrong: Would updating xmlsec to 2.3.0 not also mean to
update woodstox-core to 6.2.6? That seems to be an even bigger change.
The version 6.2.6 of woodstox-core furthermore contains the following
vulnerabilities that version 5.4.0 does not:
- CVE-2022-40156
- CVE-2022-40155
- CVE-2022-40154
- CVE-2022-40153
- CVE-2022-40152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
