jmuehlner commented on code in PR #886:
URL: https://github.com/apache/guacamole-client/pull/886#discussion_r1227131667
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -1314,9 +1314,10 @@ Guacamole.Keyboard = function Keyboard(element) {
var keydownEvent = new KeydownEvent(e);
- // Ignore (but do not prevent) the "composition" keycode sent by
some
- // browsers when an IME is in use (see:
http://lists.w3.org/Archives/Public/www-dom/2010JulSep/att-0182/keyCode-spec.html)
- if (keydownEvent.keyCode === 229)
+ // Ignore (but do not prevent) the event if explicitly marked as
composing,
+ // or when the "composition" keycode sent by some browsers when an
IME is in use
+ // (see:
http://lists.w3.org/Archives/Public/www-dom/2010JulSep/att-0182/keyCode-spec.html)
+ if (e.isComposing || keydownEvent.keyCode === 229)
Review Comment:
This is needed for Firefox. Key down events during a composition event have
the `isComposing` flag set to true, but NOT the special `229` marker keycode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
