necouchman commented on code in PR #886:
URL: https://github.com/apache/guacamole-client/pull/886#discussion_r1227181474
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -1381,24 +1380,37 @@ Guacamole.Keyboard = function Keyboard(element) {
if (!markEvent(e)) return;
// Type all content written
- if (e.data && !e.isComposing) {
- element.removeEventListener("compositionend",
handleComposition, false);
+ if (e.data && !e.isComposing)
guac_keyboard.type(e.data);
- }
+
+ };
+
+ /**
+ * Handles the given "compositionstart" event, automatically removing
+ * the "input" event handler, as "input" events should only be handled
+ * IFF composition events are not provided by the browser.
Review Comment:
I suspected it might be that, but not terribly familiar with it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
