jmuehlner commented on code in PR #448:
URL: https://github.com/apache/guacamole-server/pull/448#discussion_r1227303064
##########
src/terminal/terminal.c:
##########
@@ -1575,13 +1575,13 @@ static int __guac_terminal_send_key(guac_terminal*
term, int keysym, int pressed
}
/* Track modifiers */
- if (keysym == 0xFFE3)
+ if (keysym == 0xFFE3 || keysym == 0xFFE4)
term->mod_ctrl = pressed;
- else if (keysym == 0xFFE7)
+ else if (keysym == 0xFFE7 || keysym == 0xFFE8)
term->mod_meta = pressed;
- else if (keysym == 0xFFE9)
+ else if (keysym == 0xFFE9 || keysym == 0xFFEA)
Review Comment:
Ok, I _think_ after looking at this a bit more, that this should be ok. We
might want to un-automatically translate right alt to AltGr on the frontend,
but in either case, this change should be safe here.
@mike-jumper If you could confirm that this makes sense that would be cool
because I'm not quite as up on all the ins and outs of keyboard layout stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
