mike-jumper commented on code in PR #448:
URL: https://github.com/apache/guacamole-server/pull/448#discussion_r1228365226
##########
src/terminal/terminal.c:
##########
@@ -1575,13 +1575,13 @@ static int __guac_terminal_send_key(guac_terminal*
term, int keysym, int pressed
}
/* Track modifiers */
- if (keysym == 0xFFE3)
+ if (keysym == 0xFFE3 || keysym == 0xFFE4)
term->mod_ctrl = pressed;
- else if (keysym == 0xFFE7)
+ else if (keysym == 0xFFE7 || keysym == 0xFFE8)
term->mod_meta = pressed;
- else if (keysym == 0xFFE9)
+ else if (keysym == 0xFFE9 || keysym == 0xFFEA)
Review Comment:
Yep, I agree that:
* It makes sense to handle right alt here, even though the frontend
currently assumes the right alt key is always AltGr.
* It makes sense that the frontend should cease assuming the right alt key
is AltGr, and instead do so only if the browser agrees that the local keyboard
layout defines that key as AltGr (via the details of the key event).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
