jmuehlner commented on code in PR #883:
URL: https://github.com/apache/guacamole-client/pull/883#discussion_r1228410515
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -684,14 +766,13 @@ Guacamole.SessionRecording = function
SessionRecording(source) {
// Pull the upcoming frame
var next = frames[currentFrame + 1];
- // Calculate the real timestamp corresponding to when the next
- // frame begins
- var nextRealTimestamp = next.timestamp - startVideoTimestamp +
startRealTimestamp;
+ // Add the offset to the next frame timestamp to calculate the
delay
+ var delay = toRelativeTimestamp(next.timestamp) - currentPosition;
Review Comment:
So to be clear - you're suggesting that we modify `seekToFrame` to either
advance to the next frame _or_ increment `currentPosition` depending on whether
`currentPosition + refreshInterval` >= the timestamp of the next frame?
I think that could make sense. Let me see if it's simpler than what I have
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
