jmuehlner commented on code in PR #883:
URL: https://github.com/apache/guacamole-client/pull/883#discussion_r1228628870
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -684,14 +766,13 @@ Guacamole.SessionRecording = function
SessionRecording(source) {
// Pull the upcoming frame
var next = frames[currentFrame + 1];
- // Calculate the real timestamp corresponding to when the next
- // frame begins
- var nextRealTimestamp = next.timestamp - startVideoTimestamp +
startRealTimestamp;
+ // Add the offset to the next frame timestamp to calculate the
delay
+ var delay = toRelativeTimestamp(next.timestamp) - currentPosition;
Review Comment:
How do my latest changes look? That's more or less what I'm doing, though I
didn't do do the multiple-of-`refreshInterval` thing, I just seek to the next
`refreshInterval`, or the next frame, whichever is sooner.
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -32,8 +32,13 @@ var Guacamole = Guacamole || {};
* @param {!Blob|Guacamole.Tunnel} source
* The Blob from which the instructions of the recording should
* be read.
+ * @param {number} refreshInterval
+ * The minimum number of milliseconds between updates to the recording
+ * position through the provided onseek() callback. If non-positive, this
+ * parameter will be ignored, and the recording position will only be
+ * updated when seek requests are made, or when new frames are rendered.
Review Comment:
Sure, fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
