jmuehlner commented on code in PR #883:
URL: https://github.com/apache/guacamole-client/pull/883#discussion_r1231280310
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -678,20 +727,62 @@ Guacamole.SessionRecording = function
SessionRecording(source) {
*/
var continuePlayback = function continuePlayback() {
+ // Do not continue playback if the recording is paused
+ if (!recording.isPlaying())
+ return;
+
// If frames remain after advancing, schedule next frame
if (currentFrame + 1 < frames.length) {
// Pull the upcoming frame
var next = frames[currentFrame + 1];
- // Calculate the real timestamp corresponding to when the next
- // frame begins
- var nextRealTimestamp = next.timestamp - startVideoTimestamp +
startRealTimestamp;
+ // The position at which the next frame should be rendered
+ var nextFramePosition = toRelativeTimestamp(next.timestamp);
Review Comment:
Oops, yeah I did indeed remove that. It was unclear at the time why it was
needed, but that makes sense. I'll put it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
