necouchman commented on code in PR #450: URL: https://github.com/apache/guacamole-server/pull/450#discussion_r1247289757
########## src/common-ssh/common-ssh/user.h: ########## @@ -44,6 +44,12 @@ typedef struct guac_common_ssh_user { */ guac_common_ssh_key* private_key; + /** + * The public key which should be used to authenticate this user, if any, + * or NULL if a password or just a private key will be used instead. + */ + char* public_key; Review Comment: Okay, I see - I had to read the the Red Hat page linked on the Jira issue to actually understand the point of what was going on, here. I think the naming as you have it is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org