necouchman commented on code in PR #450:
URL: https://github.com/apache/guacamole-server/pull/450#discussion_r1260033463
##########
src/protocols/ssh/settings.h:
##########
@@ -93,6 +93,12 @@ typedef struct guac_ssh_settings {
*/
char* key_passphrase;
+ /**
+ * The public key, if any. If no public key is
+ * specified, this will be NULL.
+ */
Review Comment:
For consistency, can you please:
* Mention the base64-encoding (as above with `key_base64`
* Extended the length of the lines for the comment to the same length as the
ones around it (roughly 80 characters).
##########
src/common-ssh/common-ssh/user.h:
##########
@@ -104,5 +110,22 @@ void
guac_common_ssh_user_set_password(guac_common_ssh_user* user,
int guac_common_ssh_user_import_key(guac_common_ssh_user* user,
char* private_key, char* passphrase);
+/**
+ * Imports the given public key, associating that key with the given user.
+ * If the public key is imported successfully, it will be used for
+ * future authentication attempts.
+ *
+ * @param user
+ * The user to associate with the given private key.
+ *
+ * @param public_key
Review Comment:
This looks to be missing the documentation on the parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
