mike-jumper commented on PR #902: URL: https://github.com/apache/guacamole-client/pull/902#issuecomment-1646242309
This looks reasonable to me, though I think it should be something that's determined by the implementation. What about adding a function like `isIdentifierCaseSensitive()` to `Identifiable`, with a default implementation that just returns `true`? The `equals()` comparison could then take that into account (`hashCode()` would need to do the same). The other issue will be with database queries. IIRC, MySQL/MariaDB is case-insensitive for username queries, but PostgreSQL is case-sensitive. We would need to somehow allow for MySQL/MariaDB to optionally consider case and for PostgreSQL to optionally ignore case ... ideally without making any schema changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
