mike-jumper commented on PR #902: URL: https://github.com/apache/guacamole-client/pull/902#issuecomment-2002631929
Here, since the relevant column from the database result is `affected_name` and that is indeed a string, the `jdbcType` here _should_ also be `VARCHAR`. This probably only works as-is because: * The databases we support and their drivers are forgiving in this area. * According to [the MyBatis documentation](https://mybatis.org/mybatis-3/sqlmap-xml.html#id-result), the `jdbcType` attribute is only required for nullable columns during `INSERT`/`UPDATE`/`DELETE`. BUT, since result maps are only relevant to `SELECT` queries, this seems a rather long-winded way of stating that the declared `jdbcType` has no impact on result maps. I can't find any examples in the MyBatis documentation that show `jdbcType` ever being used for any `<result>`, so this may well be unnecessary. You're correct that absolutely all of the `Identifiable` objects within the JDBC auth use identifiers that happen to be integers, with the exceptions of users and groups which instead use the username / group name. The integer IDs of users and groups are used only internally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
