necouchman commented on code in PR #673:
URL: https://github.com/apache/guacamole-client/pull/673#discussion_r1413083651


##########
guacamole/src/main/frontend/src/app/rest/types/UserGroup.js:
##########
@@ -42,6 +42,11 @@ angular.module('rest').factory('UserGroup', [function 
defineUserGroup() {
          * @type String
          */
         this.identifier = template.identifier;
+        
+        /**
+         * True if this user group is disabled, otherwise false.
+         */

Review Comment:
   Done, I think - I can never keep straight when you should use upper-case 
types (`Boolean`) vs. lower-case (`boolean`), so let me know if I guessed 
incorrectly...



##########
guacamole/src/main/frontend/src/app/rest/types/User.js:
##########
@@ -61,6 +61,11 @@ angular.module('rest').factory('User', [function 
defineUser() {
          * @type Number
          */
         this.lastActive = template.lastActive;
+        
+        /**
+         * True if this user account is disabled, otherwise false.
+         */

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to