mike-jumper commented on code in PR #673:
URL: https://github.com/apache/guacamole-client/pull/673#discussion_r1549012599
##########
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Identifiable.java:
##########
@@ -43,5 +43,26 @@ public interface Identifiable {
* The identifier to assign.
*/
public void setIdentifier(String identifier);
+
+ /**
+ * Returns true if this object is disabled, otherwise false.
+ *
+ * @return
+ * True if this user account is disabled, otherwise false.
Review Comment:
"user account" -> "object"
##########
guacamole-ext/src/main/java/org/apache/guacamole/net/auth/Identifiable.java:
##########
@@ -43,5 +43,26 @@ public interface Identifiable {
* The identifier to assign.
*/
public void setIdentifier(String identifier);
+
+ /**
+ * Returns true if this object is disabled, otherwise false.
+ *
+ * @return
+ * True if this user account is disabled, otherwise false.
+ */
+ default public boolean isDisabled() {
+ return false;
+ }
+
+ /**
+ * Set the disabled status of this object to the boolean value provided,
+ * true if the object should be disabled, otherwise false.
+ *
+ * @param disabled
+ * True if the object should be disabled, otherwise false.
+ */
+ default public void setDisabled(boolean disabled) {
Review Comment:
I'm not sure `Identifiable` is the best place for this unless an object
having a unique identifier naturally implies that it may be disabled.
What do you think of moving this to a dedicated interface, like
`Disableable`, and applying that interface only to the specific objects that we
are applying that property to?
In that case, these default implementations would still need to provided on
`User` and `UserGroup`, but the aspect of being disableable wouldn't get
automatically inherited by every object that can be identified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
