necouchman commented on PR #946: URL: https://github.com/apache/guacamole-client/pull/946#issuecomment-1902784259
@pp7En Thanks for this contribution! I think this is a great capability to have. I do have a couple of overall comments for you before even reviewing the code: * All changes need to have a Jira issue, and the PR and commit messages need to be tagged with that commit message. See other pull requests, particularly merged ones, for guidance. See this page on our website for general guidance: https://guacamole.apache.org/open-source/. * This seems like the kind of extension that might be best integrated as a sub-module of the guacamole-auth-sso, where things like SAML, OpenID, and CAS support live, particularly as I believe the Nextcloud trusted sites features uses OAuth/OIDC? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
