pp7En commented on PR #946: URL: https://github.com/apache/guacamole-client/pull/946#issuecomment-1904428380
Thanks for your quick feedback. > All changes need to have a Jira issue, and the PR and commit messages need to be tagged with that commit message. See other pull requests, particularly merged ones, for guidance. See this page on our website for general guidance: https://guacamole.apache.org/open-source/. I will create a Jira ticket and a new pull request and consider these things. > This seems like the kind of extension that might be best integrated as a sub-module of the guacamole-auth-sso, where things like SAML, OpenID, and CAS support live, particularly as I believe the Nextcloud trusted sites features uses OAuth/OIDC? Depending on the user, the Nextcloud app only generates a JWT as a URL parameter. The Nextcloud admin can create an "external site" for everyone or groups. The public key must then be added to Guacamole. This page will be added to the main menu and embedded. I think the Nextcloud JWT can be used directly for authentication, but these current code changes use the JWT very simply. The Guacamole login credentials are still necessary. If the JWT is valid, the login page will be displayed and if not it will not be displayed because of the exception. It's a good idea to login directly through the JWT. I will try that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
