jmuehlner commented on code in PR #497:
URL: https://github.com/apache/guacamole-server/pull/497#discussion_r1523705322
##########
src/protocols/rdp/rdp.c:
##########
@@ -537,6 +536,7 @@ static int guac_rdp_handle_connection(guac_client* client) {
}
/* Upgrade to write lock again for further exclusive operations */
+ guac_rwlock_release_lock(&(rdp_client->lock));
Review Comment:
This shouldn't be necessary - the guac rwlock is set up to handle upgrading
from a read lock to a write lock just by calling
`guac_rwlock_acquire_write_lock`. I don't think coverity fully understands how
all this works (either that, or _I'm_ confused).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
