aleitner commented on code in PR #497:
URL: https://github.com/apache/guacamole-server/pull/497#discussion_r1523983564
##########
src/protocols/rdp/rdp.c:
##########
@@ -537,6 +536,7 @@ static int guac_rdp_handle_connection(guac_client* client) {
}
/* Upgrade to write lock again for further exclusive operations */
+ guac_rwlock_release_lock(&(rdp_client->lock));
Review Comment:
From what I read it seems like upgrading to a write lock adds a layer on top
of the read locks and the still requires a free for each layer. With my
understanding of the locks we were missing an unlock and so I figured it was
more straight forward this way and not necessary in this case to layer the
locks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
