CooperDActor commented on PR #515: URL: https://github.com/apache/guacamole-server/pull/515#issuecomment-2085304163
> @CooperDActor : Thanks, again, for jumping in and contributing. > > You will definitely need a Jira ticket for this. Creating an account and ticket is pretty easy: > > * Go to our Jira page (https://issues.apache.org/jira/projects/GUACAMOLE/issues).---- under issues get me a t-issue okay if you dont like that joke u have a cold heart but really under issues or where?? thats why I wasn't doing it > * At the top of the page, click the "Self serve sign-up page" link and request an account. > * Once your account is created, log in and create the Jira issue. > * Once you've created the issue, update the pull request and commit messages with the Jira issue (GUACAMOLE-XXXX:). > > Beyond that, I have some comments below for the actual script. And, in general, I still have a couple of concerns about this: > > * I'm not crazy about the name `Depend-on/Bash.sh` - first, IMHO, everything should be lower-case, and, second, I'd much prefer a directory called "contrib" or something like that if we're going to start collecting items like this. I can imagine that there may be other things, like RPM spec files, that would fit into this category of items that people might want to work on and contribute to the project, and I'd rather create a broader place to catch that information. --- this is not an insult but think of better names here's how I think of it contrib wait contribute maybe someone put malicious code In it NUP NUP NUP just like my mother I could put dependencies but autocorrect saved me there > * You'll also need to add the Apache 2.0 license header to the top of the shell script - see https://github.com/apache/guacamole-server/blob/main/src/guacd-docker/bin/build-all.sh as an example.---- okay > * The title of the pull request should be descriptive of what the changes are you are trying to make - for example, something like "Create a shell script to help manage build dependencies" -- next time or if I can I will edit it > * The commit messages should also be descriptive and helpful in determining what has changed. See https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/.-- will do from now on > * Finally, 7 commits for a single shell script seems a bit excessive - you might consider squashing down to one or two commits. ----- I made it simple first time they wanted more if you can as I dont know how. you could squash it down (adding you to the contrib on my guac folder so you can edit) if you need/want -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
