necouchman commented on code in PR #515:
URL: https://github.com/apache/guacamole-server/pull/515#discussion_r1586186578
##########
Depend-on/Bash.sh:
##########
@@ -0,0 +1,221 @@
+#!/bin/bash
+
+identify_and_run() {
+ os=$(uname)
+ if [ "$os" = "Linux" ]; then
+ distro=$(lsb_release -si)
Review Comment:
Even if the plan is to stick with `lsb_release` for this detection, this
just highlights the other comment I made - that the default case for the
subsequent `case` statement should not be to assume that SuSE is in use, but to
provide an error that tells the user something useful: "Your distribution was
not detected, please make sure your distribution supports the lsb_release
command" - or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
