jmuehlner commented on code in PR #474:
URL: https://github.com/apache/guacamole-server/pull/474#discussion_r1614093029


##########
src/protocols/rdp/channels/rail.c:
##########
@@ -86,6 +74,7 @@ static UINT 
guac_rdp_rail_complete_handshake(RailClientContext* rail) {
     };
 
     /* Send client handshake response */
+    guac_client_log(client, GUAC_LOG_DEBUG, "Sending RAIL handshake.");

Review Comment:
   The DEBUG-level messages in this file seem more TRACEy than DEBUGy, no? 
   
   Having these identical DEBUG messages appear in the log every single time 
the handshake is completed feels like overkill to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to