necouchman commented on code in PR #474: URL: https://github.com/apache/guacamole-server/pull/474#discussion_r1617997230
########## src/protocols/rdp/channels/rail.h: ########## @@ -20,7 +20,34 @@ #ifndef GUAC_RDP_CHANNELS_RAIL_H #define GUAC_RDP_CHANNELS_RAIL_H +#include "config.h" + #include <freerdp/freerdp.h> +#include <freerdp/window.h> + +#ifdef FREERDP_RAIL_CALLBACKS_REQUIRE_CONST +/** + * FreeRDP 2.0.0-rc4 and newer requires the final argument for all RAIL Review Comment: Well, it depends on how many arguments the functions have. To your point, the `WindowUpdate` callback has two arguments, both of which need to be `const`; however, the `ServerHandshake` and `ServerHandshakeEx` callbacks only have a single argument that is `const`. I've tweaked the comment via rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
