mike-jumper commented on code in PR #987:
URL: https://github.com/apache/guacamole-client/pull/987#discussion_r1694032532
##########
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java:
##########
@@ -63,7 +65,36 @@ public class AuthenticationProviderService {
/**
* The prefix that will be used when generating tokens.
*/
- public static final String LDAP_ATTRIBUTE_TOKEN_PREFIX = "LDAP_";
+ public static final String LDAP_TOKEN_PREFIX = "LDAP_";
+
+ /**
+ * Regular expression that extracts the Windows / Active Directory domain
+ * from a username in either of the following formats: down-level logon
+ * ("DOMAIN\\username") or UPN ("username@domain"). If the username is in
+ * "DOMAIN\\username" format, the domain will be stored in the first
Review Comment:
@necouchman I ran into this recently, as well. Bizarrely, Java interprets
backslash escapes in comments. Without the double backslash, that `\u` will be
interpreted as an invalid Unicode escape and will not compile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
