necouchman commented on code in PR #987:
URL: https://github.com/apache/guacamole-client/pull/987#discussion_r1701682388
##########
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java:
##########
@@ -354,14 +425,19 @@ private Map<String, String>
getAttributeTokens(ConnectedLDAPConfiguration config
// Convert each retrieved attribute into a corresponding token
for (Attribute attr : attributes) {
tokens.put(TokenName.canonicalize(attr.getId(),
- LDAP_ATTRIBUTE_TOKEN_PREFIX), attr.getString());
+ LDAP_TOKEN_PREFIX), attr.getString());
}
-
}
catch (LdapException e) {
throw new GuacamoleServerException("Could not query LDAP user
attributes.", e);
}
+ // Extract the domain (ie: Windows / Active Directory domain) from the
+ // user's credentials
+ String domainName = getUserDomain(credentials);
Review Comment:
Okay, seems safe to leave in there, the.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
