jmuehlner commented on code in PR #525: URL: https://github.com/apache/guacamole-server/pull/525#discussion_r1742698522
########## src/terminal/buffer.c: ########## @@ -19,13 +19,85 @@ #include "terminal/buffer.h" #include "terminal/common.h" +#include "terminal/terminal.h" +#include <guacamole/assert.h> #include <guacamole/mem.h> +#include <stdbool.h> #include <stdlib.h> #include <string.h> -guac_terminal_buffer* guac_terminal_buffer_alloc(int rows, guac_terminal_char* default_character) { +#define GUAC_TERMINAL_BUFFER_ROW_MIN_SIZE 256 Review Comment: This constant should be documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org