Re: [PR] GUACAMOLE-377: Add libguac "guac_display" API for easy and efficient rendering. [guacamole-server]

[via GitHub]

mike-jumper commented on PR #525:
URL: https://github.com/apache/guacamole-server/pull/525#issuecomment-2351110467

   > In testing this, I'm seeing some visual artifacts where windows dragged 
around in VNC have bits of the window content spread around, e.g. 
![image](https://private-user-images.githubusercontent.com/4633119/366569735-8b417b40-435a-433e-bd67-6091bc3748cd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYzNDA5OTMsIm5iZiI6MTcyNjM0MDY5MywicGF0aCI6Ii80NjMzMTE5LzM2NjU2OTczNS04YjQxN2I0MC00MzVhLTQzM2UtYmQ2Ny02MDkxYmMzNzQ4Y2QucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MTRUMTkwNDUzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Mjk1ZTNhNjNlMTljODIyYTY0ZDc3NTQ4ZDcwYWYzYjNkNWU5Nzk5M2YwMjAzODM5NmU5MGU0NDg3OTI3NTgxMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.gspgCl2LvSPFLyPaFiUmShkvkH-fod2fQAmYmIARk1U)
   
   This should now be resolved - it was caused by the `GotCopyRect()` function 
having been overridden. Previously, this was no issue because we used our own 
buffer. Now that we're reusing libvncclient's buffer, the original 
`GotCopyRect()` needs to be called or that buffer won't be updated with respect 
to received `CopyRect` updates.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org