necouchman commented on PR #1028: URL: https://github.com/apache/guacamole-client/pull/1028#issuecomment-2411576863
@corentin-soriano Okay, I've corrected the latest issue you identified with non-JDBC connections inserting history records into the database in this pull request. @mike-jumper You might take a look and make sure that what I did is sane - I couldn't pull the `JDBCEnvironment` injection into the `HistoryTrackingConnection` class, so I ended up using the `isCaseSensitive()` method from the `currentUser`. I _think_ this is sane, but let me know if anything seems off about that... I've also tested out things like creating users, creating connections, assigning permissions, etc., and I'm not seeing any issues, so I'm going to mark this as ready to review. I'll continue testing a few other scenarios - enabling/disabling case sensitivity, add some usernames with mixed case, etc., and see if I can break anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
