necouchman commented on PR #1028: URL: https://github.com/apache/guacamole-client/pull/1028#issuecomment-2422258034
> Hm ... maybe what I was thinking is actually backwards, and we should instead: > > * Use the `*-case-sensitive-usernames` properties to dictate only whether users authenticating _via that extension_ have case-sensitive usernames. > * Extensions that consume usernames from other extensions _should_ honor the `isCaseSensitive()` value when comparing identities. I'll go back through the previous changes and see what needs to be done to rework things using this logic. > * In the equality comparison for `AbstractIdentifiable`, we need some sane way to resolve what happens if you compare a case-sensitive identifier with a case-insensitive identifier. I've pushed a commit that I think tackles this particular issue without too much hassle - let me know if that looks okay to you. > > Otherwise things stop making sense. The JSON auth has a `json-case-sensitive-usernames` property but does not consume external identifiers, so the intent of that property _has_ to be declaring the intent of what other extensions should do with identifiers from JSON auth. For that to be useful, we would need to meaningfully consume `isCaseSensitive()`, but most of the logic around consuming external identifiers on the database side depends solely on the database's `*-case-sensitive-usernames` property. > > I'm starting to thing these changes have part of the right idea, and we need to change the rest to match. Yeah, this makes sense to me. I'll review and see what changes need to be made to implement this logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
