mike-jumper commented on PR #1028: URL: https://github.com/apache/guacamole-client/pull/1028#issuecomment-2448651425
I think we do need to switch over to the monolithic enable/disable option. As I review, I'm running into things like handling of usernames within history records, and there doesn't seem to be any way we can handle differences in case sensitivity sanely unless there is a platform-wide option that states how all installed extensions are expected to behave. For example, let's say there are two authentication systems installed: 1. LDAP (configured to be case-insensitive) 2. PostgreSQL (configured to be case-sensitive) If a user `SOMEONE` logs in with LDAP and accesses a connection, and then a user `someone` logs into PostgreSQL and accesses another connection, are they the same user? If a group in PostgreSQL includes the PostgreSQL user `someone`, does that include the LDAP user `SOMEONE`? With a platform-wide option, things are completely unambiguous and everything is in agreement. With extension-specific options, things make sense as long as everything is manually configured to be in agreement, but stop making sense once there is any disagreement between extensions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
