necouchman commented on code in PR #1028:
URL: https://github.com/apache/guacamole-client/pull/1028#discussion_r1835408758
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/permission/PermissionService.java:
##########
@@ -43,6 +44,41 @@
public interface PermissionService<PermissionSetType extends
PermissionSet<PermissionType>,
PermissionType extends Permission> {
+ /**
+ * Return the current case-sensitivity setting, allowing the system to
+ * determine if usernames and/or group names should be treated as case-
+ * sensitive.
+ *
+ * @return
+ * The current case-sensitivity configuration.
+ *
+ * @throws GuacamoleException
+ * If an error occurs retrieving configuration information related to
+ * case-sensitivity.
+ */
+ default CaseSensitivity getCaseSensitivity() throws GuacamoleException {
+
+ // By default identifiers are case-sensitive.
+ return CaseSensitivity.ENABLED;
+ }
+
+ /**
+ * Return "true" if group names should be treated as case-sensitive,
+ * otherwise "false".
+ *
+ * @return
+ * "true" if group names should be treated as case-sensitive, otherwise
+ * "false".
+ *
+ * @throws GuacamoleException
+ * If an error occurs retrieving configuration information related to
+ * case-sensitivity.
+ */
+ default boolean getCaseSensitiveGroupNames() throws GuacamoleException {
+ // By default group names are case-sensitive.
+ return true;
+ }
Review Comment:
Must have been a left-over from the previous implementation iterations.
Removed via rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
