necouchman commented on code in PR #1028:
URL: https://github.com/apache/guacamole-client/pull/1028#discussion_r1835409153
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/AbstractGuacamoleTunnelService.java:
##########
@@ -637,8 +638,20 @@ private List<ModeledConnection>
getBalancedConnections(ModeledAuthenticatedUser
if (connectionGroup.isSessionAffinityEnabled())
identifiers = getPreferredConnections(user, identifiers);
+ CaseSensitivity caseSensitivity = CaseSensitivity.ENABLED;
+ try {
+ caseSensitivity = environment.getCaseSensitivity();
+ }
+ catch (GuacamoleException e) {
+ logger.warn("Error trying to retrieve case-sensitivity
configuration, "
+ + "usernames and group names will be treated as case-"
+ + "sensitive.", e);
Review Comment:
I've fixed this one - I'll go back through and try to make sure I caught it
everywhere...
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledUser.java:
##########
@@ -792,11 +792,12 @@ public boolean isSkeleton() {
@Override
public boolean isCaseSensitive() {
try {
- return environment.getCaseSensitiveUsernames();
+ return environment.getCaseSensitivity().caseSensitiveUsernames();
}
catch (GuacamoleException e) {
- logger.error("Failed to retrieve the configuration for
case-sensitive usernames: {}."
- + " Usernames comparisons will be case-sensitive.",
e.getMessage());
+ logger.error("Failed to retrieve the configuration for
case-sensitivity, "
+ + "username comparisons will be case-sensitive.",
+ e.getMessage());
Review Comment:
Added via rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
