mike-jumper commented on code in PR #564:
URL: https://github.com/apache/guacamole-server/pull/564#discussion_r1859074264
##########
src/terminal/terminal/terminal.h:
##########
@@ -180,6 +180,8 @@ typedef guac_stream*
guac_terminal_file_download_handler(guac_client* client, ch
*/
typedef struct guac_terminal_options {
+ int clipboard_buffer_size;
Review Comment:
Please document.
##########
src/common/common/clipboard.h:
##########
@@ -72,8 +72,10 @@ typedef struct guac_common_clipboard {
/**
* Creates a new clipboard.
+ *
+ * @param buffer_size The buffer size in bytes.
Review Comment:
The style for `@param` should be with the description of the parameter
starting on the next line, indented by one level. For example:
https://github.com/apache/guacamole-server/blob/8e75eea9ce7e4b672f55bfb4068b927255156dc0/src/libguac/guacamole/client.h#L445-L455
You'll see some older documentation using the older style, but we are moving
to the new style for any new/modified code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
