eugen-keeper commented on code in PR #564:
URL: https://github.com/apache/guacamole-server/pull/564#discussion_r1927637260
##########
src/protocols/vnc/clipboard.c:
##########
@@ -103,20 +103,23 @@ int guac_vnc_clipboard_end_handler(guac_user* user,
guac_stream* stream) {
guac_vnc_client* vnc_client = (guac_vnc_client*) user->client->data;
rfbClient* rfb_client = vnc_client->rfb_client;
- char output_data[GUAC_COMMON_CLIPBOARD_MAX_LENGTH];
+ int output_buf_size = vnc_client->clipboard->available;
Review Comment:
- Added NULL check to the VNC functions the same it is done for RDP
- Moved RDP and VNC clipboard allocation into user join handlers. So now it
happens before the client threads start. I believe this is not necessary for
terminal based protocols because I had not moved guac_common_clipboard_alloc
originally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
