mike-jumper commented on code in PR #570: URL: https://github.com/apache/guacamole-server/pull/570#discussion_r1915783455
########## src/protocols/rdp/keymaps/ru_ru_qwerty.keymap: ########## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +parent "base" +name "ru-ru-qwerty" +# We use the "KBD_US" layout because we switch the language, not the layout +freerdp "KBD_US" Review Comment: Can you clarify why/how this is the case? I would think one of the following mutually-exclusive possibilities has to be true: * This is, in fact, a keyboard layout and needs to point to the RDP layout so that it can be sent to the RDP server. I think the correct value here is likely `KBD_RUSSIAN`. * This isn't a keyboard layout and we shouldn't be defining it at all. Assuming this is indeed a keyboard layout that needs a definition, I'm looking around to find examples of that keyboard, and so far they don't exactly align: https://en.wikipedia.org/wiki/JCUKEN (just Cyrillic keys with no Latin-only mode) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
