mike-jumper commented on code in PR #574: URL: https://github.com/apache/guacamole-server/pull/574#discussion_r1957510075
########## src/protocols/rdp/keymaps/ru_ru_qwerty.keymap: ########## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +parent "base" +name "ru-ru-qwerty" +freerdp "KBD_RUSSIAN" + +# Let's define the scan codes of the main Latin keys +# +map -caps -shift 0x10..0x1B 0x2B ~ "qwertyuiop[]\" +map -caps -shift 0x1E..0x28 ~ "asdfghjkl;'" +map -caps -shift 0x2C..0x35 ~ "zxcvbnm,./" + +map -caps +shift 0x10..0x1B 0x2B ~ "QWERTYUIOP{}|" +map -caps +shift 0x1E..0x28 ~ "ASDFGHJKL:"" +map -caps +shift 0x2C..0x35 ~ "ZXCVBNM<>?" + +map +caps -shift 0x10..0x1B 0x2B ~ "QWERTYUIOP[]\" +map +caps -shift 0x1E..0x28 ~ "ASDFGHJKL;'" +map +caps -shift 0x2C..0x35 ~ "ZXCVBNM,./" + +map +caps +shift 0x10..0x1B 0x2B ~ "qwertyuiop{}|" +map +caps +shift 0x1E..0x28 ~ "asdfghjkl:"" +map +caps +shift 0x2C..0x35 ~ "zxcvbnm<>?" + +# Let's define the scan codes of the main Russian keys +# +map -caps -shift 0x29 0x02..0x0D ~ "ё1234567890-=" +map -caps -shift 0x10..0x1B 0x2B ~ "йцукенгшщзхъ\" +map -caps -shift 0x1E..0x28 ~ "фывапролджэ" +map -caps -shift 0x2C..0x35 ~ "ячсмитьбю." + +map -caps +shift 0x29 0x02..0x0D ~ "Ё!"№;%:?*()_+" +map -caps +shift 0x10..0x1B 0x2B ~ "ЙЦУКЕНГШЩЗХЪ/" +map -caps +shift 0x1E..0x28 ~ "ФЫВАПРОЛДЖЭ" +map -caps +shift 0x2C..0x35 ~ "ЯЧСМИТЬБЮ," + +map +caps -shift 0x29 0x02..0x0D ~ "Ё1234567890-=" +map +caps -shift 0x10..0x1B 0x2B ~ "ЙЦУКЕНГШЩЗХЪ\" +map +caps -shift 0x1E..0x28 ~ "ФЫВАПРОЛДЖЭ" +map +caps -shift 0x2C..0x35 ~ "ЯЧСМИТЬБЮ," + +map +caps +shift 0x29 0x02..0x0D ~ "ё!"№;%:?*()_+" +map +caps +shift 0x10..0x1B 0x2B ~ "йцукенгшщзхъ/" Review Comment: This (and other lines) duplicates the same scancodes and modifier combination as a previous line: ``` map +caps +shift 0x10..0x1B 0x2B ~ "qwertyuiop{}|" ``` There needs to be something that distinguishes the context of typing these characters for the mapping to work correctly. For example, if the user presses "q" or "й", this map will result in the same sequence of scancodes being sent, but that sequence will not necessarily be interpreted to produce "q" (or "й"). Proper behavior will depend on some sort of additional state that Guacamole isn't aware of, and the intent of the user may not match what ultimately ends up typed. Is there something else that needs to be supported by these keymaps for this to be unambiguous? Does the Russian keyboard have additional modifier keys or state that needs to be represented? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
