YAGA29 commented on PR #1062: URL: https://github.com/apache/guacamole-client/pull/1062#issuecomment-2683266392
> @YAGA29 Thank you for submitting this PR and helping out with these translations. I've noted a few specifics, but, generally: @necouchman Thank you for your feedback. My responses below. > > * You don't need to add items to the translation that aren't actually being translated, as Guacamole will automatically pull from the default (English) translation. Ok perfect, I'll remove these items. > * I'm unsure about the addition of the space before every colon (`:`). As we don't do this in other translations, is there some specific reason to do it in the French translation? In French, the rule is to add a non-breaking space before colon and a space after colon. https://fr.wikipedia.org/wiki/Ponctuation I don't know if we can use a nbsp in the translation file. But that's just a small detail. Please let me know what you prefer, I can remove the space before every colon. > > Also, please re-base this PR against the `apache:patch` branch - the changes for 1.6.0 are already pretty well fixed, and this will not go into that release. Ok perfect, I'll do that by the end of the week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
