aleitner commented on PR #530: URL: https://github.com/apache/guacamole-server/pull/530#issuecomment-3629527559
Hi, thanks for putting together this PR! I've been working on a similar implementation but when I went to see if an issue for clipboard recordings already existed I found this PR. I'd love to merge your PR instead as it's already looking great. I just have one change I'd suggest: in addition to recording clipboard data sent to the RDP server (via the `guac_rdp_clipboard_handler`, `guac_rdp_clipboard_blob_handler`, and `guac_rdp_clipboard_end_handler` flow), it would be valuable to also record clipboard data received from the RDP server by adding a call within `guac_rdp_cliprdr_format_data_response` where we call `guac_common_clipboard_send`. Currently, this PR captures clipboard content when a user pastes into the remote session (client → server), but it doesn't capture when the clipboard is modified on the remote desktop itself (server → client). Adding recording support in `guac_rdp_cliprdr_format_data_response` would capture both directions, providing a complete picture of clipboard activity during the session. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
