sschiffli commented on code in PR #1155:
URL: https://github.com/apache/guacamole-client/pull/1155#discussion_r2747384454
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -285,8 +285,10 @@ Guacamole.Keyboard = function Keyboard(element) {
this.keysym = keysym_from_key_identifier(this.keyIdentifier,
this.location, this.modifiers.shift);
// If a key is pressed while meta is held down, the keyup will
- // never be sent in Chrome (bug #108404)
- if (this.modifiers.meta && this.keysym !== 0xFFE7 && this.keysym !==
0xFFE8)
+ // never be sent in Chrome (bug #108404). Modifier keys are excluded
+ // from this workaround as they have reliable keyup events and need
+ // to be held down simultaneously with Meta.
+ if (this.modifiers.meta && !isModifierKey(this.keysym))
Review Comment:
I could see an argument where this should be a separate issue, as this is
needed to support CMD+Shift+Click (not CMD+Click), so let me know what you
think or if a rewording of the JIRA/PR would be sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
