necouchman commented on code in PR #1155:
URL: https://github.com/apache/guacamole-client/pull/1155#discussion_r2747469099
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -285,8 +285,10 @@ Guacamole.Keyboard = function Keyboard(element) {
this.keysym = keysym_from_key_identifier(this.keyIdentifier,
this.location, this.modifiers.shift);
// If a key is pressed while meta is held down, the keyup will
- // never be sent in Chrome (bug #108404)
- if (this.modifiers.meta && this.keysym !== 0xFFE7 && this.keysym !==
0xFFE8)
+ // never be sent in Chrome (bug #108404). Modifier keys are excluded
+ // from this workaround as they have reliable keyup events and need
+ // to be held down simultaneously with Meta.
+ if (this.modifiers.meta && !isModifierKey(this.keysym))
Review Comment:
I think it's fine in here. You can reword the Jira issue if you want to make
it more clear that it's working to support both Shift+CMD an Cmd, but no major
concerns from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
