bbennett-ks commented on code in PR #669:
URL: https://github.com/apache/guacamole-server/pull/669#discussion_r3182955650
##########
src/common/iconv.c:
##########
@@ -203,6 +348,22 @@ int GUAC_READ_ISO8859_1_NORMALIZED(const char** input, int
remaining) {
return guac_iconv_read_normalized(GUAC_READ_ISO8859_1, input, remaining);
}
+int GUAC_READ_MACROMAN(const char** input, int remaining) {
+
+ int value = (unsigned char) **input;
+ (*input)++;
+
+ if (value >= 0x80)
Review Comment:
I've added clarifying comments. The There's no need to check upper bounds,
as array size is 128. However, I've added a defensive check..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
