bbennett-ks commented on code in PR #669:
URL: https://github.com/apache/guacamole-server/pull/669#discussion_r3182976890
##########
src/common/iconv.c:
##########
@@ -305,3 +466,33 @@ void GUAC_WRITE_ISO8859_1_CRLF(char** output, int
remaining, int value) {
guac_iconv_write_crlf(GUAC_WRITE_ISO8859_1, output, remaining, value);
}
+void GUAC_WRITE_MACROMAN(char** output, int remaining, int value) {
+
+ /* ASCII range is identical */
+ if (value < 0x80) {
Review Comment:
I've added comments and a defensive check. I've also replaced the O(N) brute
force search with a **bsearch()** (O(log N)) for **GUAC_WRITE_CP1252** and
**GUAC_WRITE_MACROMAN**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
