Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74790860
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/LDAPGuacamoleProperties.java
---
@@ -145,4 +145,16 @@ private LDAPGuacamoleProperties() {}
};
+ /**
+ * The maximum number of results a LDAP query can return.
+ */
+ public static final IntegerGuacamoleProperty LDAP_MAX_SEARCH_RESULTS =
new IntegerGuacamoleProperty() {
+
+ @Override
+ public String getName() { return "ldap-maxresults"; }
--- End diff --
Just noticed:
`LDAP_MAX_SEARCH_RESULTS` is very nice and readable, so why is the property
just `ldap-maxresults`? (Nice dash following the "ldap", but not between "max"
and "results"). For consistency with other properties used by Guacamole, this
should at least be `ldap-max-results`, though given the nice
`LDAP_MAX_SEARCH_RESULTS` name, I'd suggest `ldap-max-search-results` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
