Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/57#discussion_r74814349
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
---
@@ -86,14 +87,18 @@ private void putAllUsers(Map<String, User> users,
LDAPConnection ldapConnection,
String usernameAttribute) throws GuacamoleException {
try {
+ // Set search limits
+ LDAPSearchConstraints constraints = new LDAPSearchConstraints();
+ constraints.setMaxResults(confService.getMaxResults());
--- End diff --
Didn't notice this before, but please use 4-space indents (no tabs). I saw
that these three lines weren't quite aligned with the surrounding code, and
decided to download the patch to take a closer look. The misalignment is due to
the tabs (see yellow highlight in screenshot below):
You might have to change your editor settings to get it to stop adding tabs
instead of spaces.
Other than that, I see no further issues. With the exception of the tabs,
all looks good to me, even the commit history. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
