Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/69#discussion_r77475833
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java
---
@@ -183,6 +185,19 @@ protected ModeledConnection
acquire(RemoteAuthenticatedUser user,
@Override
public int compare(ModeledConnection a, ModeledConnection b) {
+ Directory<ConnectionGroup> directory;
+ ConnectionGroup group;
+ try {
--- End diff --
Please do not indent with tabs - our code uses a 4-space indent absolutely
everywhere. Deviating from this causes horrible readability issues like:
You may need to change your editor's settings. Even after that, it's worth
double-checking the diff to make sure something crazy like the above hasn't
happened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
