Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/69#discussion_r77476218
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/tunnel/RestrictedGuacamoleTunnelService.java
---
@@ -183,6 +185,19 @@ protected ModeledConnection
acquire(RemoteAuthenticatedUser user,
@Override
public int compare(ModeledConnection a, ModeledConnection b) {
+ Directory<ConnectionGroup> directory;
+ ConnectionGroup group;
+ try {
+ // Get connection group directory
+ directory =
a.getCurrentUser().getAuthenticationProvider().getUserContext(a.getCurrentUser()).getConnectionGroupDirectory();
+ // Get authorized connection group
+ group = directory.get(a.getParentIdentifier());
+ if (group.getType() == ConnectionGroup.Type.BALANCING)
+ return getIdleConnections(a)
--- End diff --
Magic changes in expected behavior really need to be documented. The
comparator here is earlier defined as "Sort connections in ascending order of
usage", which is being (intentionally) violated here. To avoid confusion, and
for the sake of maintainability, that behavior needs to be clearly defined just
as it previously was.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
