Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87650181
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCAuthenticationProviderService.java
---
@@ -73,8 +80,22 @@ public ModeledUserContext
getUserContext(AuthenticationProvider authenticationPr
// Retrieve user account for already-authenticated user
ModeledUser user =
userService.retrieveUser(authenticationProvider, authenticatedUser);
- if (user == null)
- return null;
+ if (user == null) {
--- End diff --
OK - I've updated the documentation of `AuthenticationProviderService`.
Turns out the documentation was even more wrong than we thought. It said "a
new placeholder account will be created for any user that does not already
exist within the database", which is leftover documentation from early
development on [GUAC-586](https://glyptodon.org/jira/browse/GUAC-586) for an
approach which we ultimately did not take.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
