Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/78#discussion_r87671874
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/AuthenticationProviderService.java
---
@@ -72,7 +71,7 @@ public AuthenticatedUser
authenticateUser(AuthenticationProvider authenticationP
*
* @return
* A new UserContext instance for the user identified by the given
- * credentials.
+ * credentials, or null if no such user exists within the database.
--- End diff --
Should we maybe mention what the meaning of returning null is? The method
itself says "allow access" and then returns null, but this comment doesn't say
anything about returning null implying allowing access.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
