Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/109#discussion_r97834919
--- Diff: guacamole/src/main/java/org/apache/guacamole/rest/APIRequest.java
---
@@ -58,6 +68,27 @@ public APIRequest(HttpServletRequest request,
super(request);
+ // Try a few methods to get client info.
+ if(request.getHeader("X-Guacamole-Client-Hostname") != null &&
request.getHeader("X-Guacamole-Client-Hostname") != "") {
+ this.remoteHost =
request.getHeader("X-Guacamole-Client-Hostname");
+ } else if(request.getHeader("X-Forwarded-For") != null &&
request.getHeader("X-Forwarded-For") != "") {
+ this.remoteHost = request.getHeader("X-Forwarded-For");
+ } else if(request.getRemoteHost() != null &&
request.getRemoteHost() != "") {
+ this.remoteHost = request.getRemoteHost();
+ } else {
+ this.remoteHost = "";
--- End diff --
Yeah, that occurred to me as I was reviewing the other changes...will
remove that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
