Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/109#discussion_r97837365
--- Diff:
guacamole-ext/src/main/java/org/apache/guacamole/token/StandardTokens.java ---
@@ -42,6 +43,16 @@
public static final String PASSWORD_TOKEN = "GUAC_PASSWORD";
/**
+ * The name of the client token added via addStandardTokens().
+ */
+ public static final String REMHOST_TOKEN = "GUAC_REMHOST";
--- End diff --
I'm not the biggest fan of "GUAC_REMHOST" and "GUAC_REMIP", given the
verbosity of other tokens ("GUAC_USERNAME" and "GUAC_PASSWORD"), the ambiguity
of "remote" in a multi-layered stack, and the specificity of "IP" compared to
the "address" property it's pulled from.
What would you think of "GUAC_CLIENT_HOSTNAME" and "GUAC_CLIENT_ADDRESS"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
